Add version to the schema#52
Merged
kumaranvram merged 1 commit intomasterfrom Apr 3, 2020
Merged
Conversation
kumaranvram
force-pushed
the
add-schema-version
branch
from
52d4c69 to
24bb57e
Compare
osamie
suggested changes
Apr 2, 2020
osamie
left a comment
osamie
left a comment
There was a problem hiding this comment.
Looks good. But one thing, why do you need the Schema.java if you already have a APISchema.java that contains your schema version information?
| import java.io.Serializable; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; |
Contributor
Author
There was a problem hiding this comment.
The APISchema.java is the template for generating the all the classes in a single file. The Schema.java is will generate the API information into a separate file when the schema is generated in a granular mode.
Removing the unnecessary imports.
kumaranvram
force-pushed
the
add-schema-version
branch
from
9599d24 to
dbc082d
Compare
Other changes: - Bump up the JDK version for CI to pass - Bump up the bundler version for CI to pass
kumaranvram
force-pushed
the
add-schema-version
branch
from
a1c6a46 to
ba51989
Compare
tristan-potter
approved these changes
Apr 3, 2020
| GraphQLSchema.new(Support::Schema.introspection_result), | ||
| package_name: 'com.shopify.graphql.support', | ||
| nest_under: 'Generated', | ||
| version: '2020-01', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding schema version to the generated code.